build table: no estimation #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests pass with rime_api_console under both wsl1 (ubuntu 23.10 64bit) and termux(aarch64), no segmentation faults happened. and I checked the output dbs of build_predict, both outputs from the platform mentioned above, are the same with the released one. with the output file I made it worked with weasel(32bit)，no segmentation faults happened. there are still dumps of weaselserver.exe, but the server not hanged. so I assume this pr has solved the segmentation faults issue. |
fxliang
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove under-estimation and don't rely on it.
Tested reproducibility on Ubuntu, termux, macOS (intel and m1).