Better Option Update Display #447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit f42b68a6fe10c0ab6663d4a41efc588979f853e9)
lotem
reviewed
Jul 20, 2021
|
Check after anniversary |
lotem
reviewed
May 1, 2022
lotem
added a commit
to lotem/librime
that referenced
this pull request
Jun 9, 2022
enable the frontend to display a message when an arbitrary option defined in the schema is updated. Closes rime#447 the option name eg. ascii_mode is passed to the notification handler function, there, get_state_label gives IME frontend the access to the human readable label for the current state of the option defined in *.schema:/switches/@*/states. when selection is changed in a radio group, more than one option in the group is updated so it only returns a non-empty label while querying the selected option.
2 tasks
lotem
added a commit
to lotem/librime
that referenced
this pull request
Jun 9, 2022
enable the frontend to display a message when an arbitrary option defined in the schema is updated. Closes rime#447 the option name eg. ascii_mode is passed to the notification handler function, there, get_state_label gives IME frontend the access to the human readable label for the current state of the option defined in *.schema:/switches/@*/states. when selection is changed in a radio group, more than one option in the group is updated so it only returns a non-empty label while querying the selected option.
lotem
added a commit
to lotem/librime
that referenced
this pull request
Jun 9, 2022
enable the frontend to display a message when an arbitrary option defined in the schema is updated. Closes rime#447 the option name eg. ascii_mode is passed to the notification handler function, there, get_state_label gives IME frontend the access to the human readable label for the current state of the option defined in *.schema:/switches/@*/states. when selection is changed in a radio group, more than one option in the group is updated so it only returns a non-empty label while querying the selected option.
|
做出来了。请过目。 新的接口函数读取状态文字的逻辑是： 按快捷键或者程序自动触发状态改变时会返回方案里定义的文字。 |
|
創建session和消session可以經常操作嗎，每次查狀態文字的時候創建一次session如何？ |
有开销的，只能尽力减小开销。另外还可能丢失状态。 应该区分几个不同的作用域，这个session对应着与一个输入法客户端的连接；比他更小的范围有（加载、切换）输入方案的生命周期；再小是以清空输入串为界的一次输入过程，而有些上下文数据是持续记录的，比如上屏历史、状态等；更小的还有一次按键处理的过程～ |
lotem
added a commit
that referenced
this pull request
Jun 10, 2022
enable the frontend to display a message when an arbitrary option defined in the schema is updated. Closes #447 the option name eg. ascii_mode is passed to the notification handler function, there, get_state_label gives IME frontend the access to the human readable label for the current state of the option defined in *.schema:/switches/@*/states. when selection is changed in a radio group, more than one option in the group is updated so it only returns a non-empty label while querying the selected option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option updates will use the
statesstring as display string. Thus users who customize switches can see the proper switch message.Also eliminates localization need.
Known issue: the message will start with a "!", since I couldn't find the source of it, currently I handle it in frontend.