Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Option Update Display #540

Merged
merged 3 commits into from Oct 23, 2022
Merged

Better Option Update Display #540

merged 3 commits into from Oct 23, 2022

Conversation

LEOYoon-Tsaw
Copy link
Member

@LEOYoon-Tsaw LEOYoon-Tsaw commented Feb 20, 2021

Addresses #535

Complements rime/librime#447

Screen_Shot.2021-02-20.at.17.46.18.mov

(cherry picked from commit ce836f6)
@lotem lotem self-requested a review July 20, 2021 18:09
(cherry picked from commit 98a5069)
@LEOYoon-Tsaw
Copy link
Member Author

Use updated API in rime/librime@8f9e9c7

@LEOYoon-Tsaw
Copy link
Member Author

Perfectly working with rime/librime@5e8aca2

@Dreamer57
Copy link

大佬,我更新这个补丁之后,切换开关后没有显示提示。

这件事说来话长。要从去年开始说起。

去年我更新了这个补丁,和librime里的这个 /rime/librime/pull/447

更新完成后,和上面视频里的效果一模一样,有提示效果。

就这样用了一年多,到8月9号的时候,我完全更新了一次squirrel和librime,同时更新了这个pr。

然后提示就没有了,弄了几天也不知道怎么回事。我用对比工具对比过所更新的代码文件。

librime里:
engine.cc
key_binder.cc
switches.cc
switcher.cc

squirrel里:
SquirrelApplicationDelegate.m

感觉文件都是最新的,但是用快捷键切换开关时,一直没有提示。

总结下:以前有,更新后没有。

大佬能不能帮忙看看可能是怎么回事,

@LEOYoon-Tsaw
Copy link
Member Author

我很難知道你具體如何編譯的,librime那邊代碼改過,這個pr也相應改過,用我編譯的吧

@Dreamer57
Copy link

今天又试了下,把其它文件也比较了一下,问题解决了。

说来尴尬,本来以为每次更新完代码,会自动合并,删除不要的代码。

librime 447那个pr,关闭了,我认为就会自动删除呀,git库里都没有,但电脑上还有,现在看来git也没有那么智能。

后来我比较所有代码文件,发现librime/src/rime/context.cc里面,多了段get/set_option_state那些,然后删了,通知就出来了。

之后又很疑惑怎么回事,以为是我自己改的,但看了半天又没看懂,觉得应该不是自己改的呀,然后又想着可能是更新的哪个pr冲突了,然后又找,找着找着,突然间,灵光一闪,察觉到是之前更新的老pr。

唉~程序的世界充满了荆棘,普通人在里面,要时刻对抗着诱惑。

这次的经历总结出的经验就是:如果还能用,就不要去动它。

@@ -43,7 +43,7 @@ style:
#label_font_face: 'Lucida Grande'
label_font_point: 18
#comment_font_face: 'Lucida Grande'
comment_font_point: 18
#comment_font_point: 18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这一行怎么注释掉了?设了这个值有什么问题吗。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

盡量保持向前兼容吧,原本用家設定了字號,而與新的comment字號不同的話,更新後就會發現和以前不一樣。

@lotem lotem merged commit ba9bbf1 into rime:master Oct 23, 2022
@LEOYoon-Tsaw LEOYoon-Tsaw deleted the UpdateDisplay branch January 27, 2023 02:02
@firedent
Copy link

firedent commented Feb 6, 2023

不习惯“中文”、“西文”的可以按照一下方式修改:

1.如果你使用的是“朙月拼音·简化字”,创建:luna_pinyin_simp.custom.yaml。如果你使用的是”朙月拼音“,创建:luna_pinyin.custom.yaml。以此类推,如果你使用的是[方案ID],创建:[方案ID].yaml。
2.将如下内容填入上一步创建的配置文件:

patch:
  switches/@0: 
    name: ascii_mode
    reset: 0
    states: ["中", "英"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants