Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chord_composer): ignore repeated keys #841

Merged
merged 2 commits into from
Mar 10, 2024
Merged

fix(chord_composer): ignore repeated keys #841

merged 2 commits into from
Mar 10, 2024

Conversation

fxliang
Copy link
Contributor

@fxliang fxliang commented Mar 8, 2024

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

with #828 chord_composer/finish_chord_on_first_key_release: true, the left keys of previous chord, may be inserted
to the new chord.

test procedure (combo_pinyin):

  1. press w l , get ce not finishchord
  2. release l, get ce finishchord, w saved to the prev_pressed_
  3. hold the w key, system may resend keydown event of w, as it still in the prev_pressed_, it will not be insert to new chord pressed_
  4. press s d j, get shi not finishchord
  5. the held w will repeat keydown event, will still be ignored.
  6. release d, finish current chord, save sj to prev_pressed_(with w deleted), repeat the new loop on and on.

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

Copy link
Member

@lotem lotem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's impossible to understand the code. Let's remove the feature if it requires such complicated logic.

@lotem lotem changed the title follow PR 828, ignore repeated keys(maybe from system) from the previous chord pressed_ fix(chord_composer): ignore repeated keys Mar 10, 2024
@lotem lotem merged commit e554510 into rime:master Mar 10, 2024
10 checks passed
@fxliang fxliang deleted the eh828 branch March 12, 2024 04:11
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
refactor: unify finish chord strategies

---------

Co-authored-by: 居戎氏 <chen.sst@gmail.com>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
refactor: unify finish chord strategies

---------

Co-authored-by: 居戎氏 <chen.sst@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants