Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(table_translator): enable encoding uniquified commit history #217

Merged
merged 1 commit into from
Aug 16, 2018
Merged

fix(table_translator): enable encoding uniquified commit history #217

merged 1 commit into from
Aug 16, 2018

Conversation

nameoverflow
Copy link
Member

Fix #184

@nameoverflow nameoverflow requested review from lotem and a team August 14, 2018 16:20
lotem
lotem approved these changes Aug 15, 2018
View reviewed changes
Copy link
Member

@lotem lotem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We may need to revisit uniquified and other structured candidate, and make phrases with every possible combination.

@nameoverflow
Copy link
Member Author

这样处理会影响多繁对一简再 unify 之后的造词吗？
还没找到关于这个机制的代码……

@lotem
Copy link
Member

lotem commented Aug 15, 2018

先不管他。
用簡繁合併後的候選字造詞也是最近要解決的問題。
不過我認爲不能只憑展開合併的候選字造詞，而應該造詞之前再查詢一次，因爲過濾器也是懶的，排序很靠後的候選字還沒有通過翻頁讀出來，就不會發生合併。

@nameoverflow nameoverflow merged commit 74e31bc into rime:master Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lotem lotem lotem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nameoverflow @lotem