General support for navigating in vertical mode

[LEOYoon-Tsaw]

The previous patch is not complete, for example

1. There's no way to navigate backwards in preedit text field
2. Up and down are still working as if not in vertical mode
3. Does not support the 4th combination with both horizontal and vertical modes on.

My fix is more general, but the patch in navigator.cc may not be idea, you may want to change it.

A known issue is that in inline preediting vertical (whether horizontal on or off) mode, preedit text on screen may be horizontal and reads left-to-right, contradicting the up and down navigating direction. But this is a conceptual conflict, where in vertical mode, reading order is right-to-left, there is no good way to support both navigating candidates right-to-left, while navigating preedit field left-to-right.

[LEOYoon-Tsaw]

navigator.cc needs updated to support vertical mode

[lotem]

navigator needs to know if preedit text is inline.
While inline, let's assume horizontal preedit text because it is the most common case.

[LEOYoon-Tsaw]

navigator needs to know if preedit text is inline.
While inline, let's assume horizontal preedit text because it is the most common case.

Even if it's inline, there needs a way to navigate the cursor. Currently, with the fix to selector, there's no way to move cursor in vertical mode, no matter it is in inline mode or not

[lotem]

navigator needs to know if preedit text is inline.
While inline, let's assume horizontal preedit text because it is the most common case.

Even if it's inline, there needs a way to navigate the cursor. Currently, with the fix to selector, there's no way to move cursor in vertical mode, no matter it is in inline mode or not

It's possible to navigate one-way to enter move-cursor mode, just as linear horizontal layout does. Admittedly it's harder to use, but I still prefer this than having to navigate with up/down.

why I haven't been working on this part: it's a little trickier to make Tab key binding work as it is now bound to Shift+Right - moving forward by syllable.

[LEOYoon-Tsaw]

But with the current binding rules, users cannot modify navigating behavior without altering selection. Leaving navigating in vertical mode harder and un-customizable is unacceptable.

[LEOYoon-Tsaw]

• Navigating the cursor in vertical mode should be as easy as before, this change will not affect people who do not use vertical mode, then why make people using vertical mode's life harder?
• Even in inline mode, there are chances that user use it because they are typing in a vertical text editor, in which case up/down moving direction makes perfect sense.
• Only if people use vertical mode with inline edit AND they are typing in horizontal text field, the up/down moving direction may seem not obvious, but still, it's JUST not obvious, not harder.
• If no better solution, this should be the most reasonable way to make vertical mode work as smoothly as possible.

[lotem]

This is really challenging. Need more time to work on this. Maybe skip the next release.

[LEOYoon-Tsaw]

This is really challenging. Need more time to work on this. Maybe skip the next release.

That’s fine, I’m using this patch myself, and I feel it’s pretty intuitive. But it’s not a perfect patch, so no need to hurry.

I suggest leave this pull open to remind there’s a todo

[LEOYoon-Tsaw]

Shot, I accidentally deleted the branch...