Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recude Memory Comsumption When Compiling Dictionaries (2) #669

Merged
merged 2 commits into from Jul 1, 2023

Conversation

WhiredPlanck
Copy link
Contributor

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes # N/A

Feature

Describe feature of pull request

Recude Memory Comsumption When Compiling Dictionaries. Yes, again.

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@lotem lotem merged commit 3e0487c into rime:master Jul 1, 2023
5 checks passed
@WhiredPlanck WhiredPlanck deleted the dict-compile-memory branch July 17, 2023 04:11
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 2, 2023
* refactor(dict_compiler.cc): release the raw codes of the raw dict entries in time

This may save about 25% memory consumption than before (1c43fe5).

* refactor(entry_collector.cc): minor refactor to pushing back RawDictEntry
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
* refactor(dict_compiler.cc): release the raw codes of the raw dict entries in time

This may save about 25% memory consumption than before (1c43fe5).

* refactor(entry_collector.cc): minor refactor to pushing back RawDictEntry
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
* refactor(dict_compiler.cc): release the raw codes of the raw dict entries in time

This may save about 25% memory consumption than before (1c43fe5).

* refactor(entry_collector.cc): minor refactor to pushing back RawDictEntry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants