Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow single thread deployment #673

Merged
merged 1 commit into from Aug 1, 2023
Merged

allow single thread deployment #673

merged 1 commit into from Aug 1, 2023

Conversation

eagleoflqj
Copy link
Member

Pull request

Issue tracker

Feature

Upstream a patch to a CMake option.
This is necessary for deploying in wasm. Ref: emscripten-core/emscripten#8988

Unit test

  • Done

Manual test

  • Done on both Linux x64 and wasm.

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@lotem lotem merged commit 97af61b into rime:master Aug 1, 2023
5 checks passed
@eagleoflqj eagleoflqj deleted the async branch August 1, 2023 17:14
groverlynn pushed a commit to groverlynn/librime that referenced this pull request Sep 27, 2023
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 2, 2023
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants