Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clang job #693

Merged
merged 2 commits into from Aug 19, 2023
Merged

Fix clang job #693

merged 2 commits into from Aug 19, 2023

Conversation

eagleoflqj
Copy link
Member

@eagleoflqj eagleoflqj commented Aug 19, 2023 •
edited

Pull request

Issue tracker

Feature

Currently both jobs use g++.

Screenshot from 2023-08-18 20-26-03

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@eagleoflqj eagleoflqj marked this pull request as draft August 19, 2023 00:38
@eagleoflqj eagleoflqj marked this pull request as ready for review August 19, 2023 00:54
@eagleoflqj
Copy link
Member Author

Screenshot from 2023-08-18 20-55-42

@eagleoflqj eagleoflqj merged commit 9180817 into rime:master Aug 19, 2023
5 checks passed
@eagleoflqj eagleoflqj deleted the clang branch August 19, 2023 00:56
rovo98 pushed a commit to rovo98/fcitx5-rime that referenced this pull request Aug 30, 2023
@wengxt
Only deploy fcitx5.yaml after maintenance is done
27fbb97 
Due to rime/librime#693, we should not call deploy_config, otherwise it
may fail the deploy since ~/.local/share/fcitx5/rime/build will fail to
be created.

In order to reapply app option, release all session afterwards.
groverlynn pushed a commit to groverlynn/librime that referenced this pull request Sep 27, 2023
@eagleoflqj @groverlynn
Fix clang job (rime#693)
cfef96b
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 2, 2023
@eagleoflqj @graphemecluster
Fix clang job (rime#693)
193e738
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
@eagleoflqj @graphemecluster
Fix clang job (rime#693)
5297784
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
@eagleoflqj @graphemecluster
Fix clang job (rime#693)
3af820e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@eagleoflqj