Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop BOOST_USE_CXX11; fix 2 cmake warnings #694

Merged
merged 1 commit into from Aug 21, 2023
Merged

drop BOOST_USE_CXX11; fix 2 cmake warnings #694

merged 1 commit into from Aug 21, 2023

Conversation

eagleoflqj
Copy link
Member

@eagleoflqj eagleoflqj commented Aug 20, 2023 •
edited

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

  • Drop the BOOST_USE_CXX11 cmake option as it's 2023.
  • Fix cmake warning of wrong command order.
    Screenshot from 2023-08-19 23-13-53
  • Fix cmake warning of project missing. This is not tested here because linux ci uses system library and windows/macos ci caches dependencies, but I tested locally with My RIME.
    Screenshot from 2023-08-19 23-16-39

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@eagleoflqj eagleoflqj marked this pull request as ready for review August 20, 2023 03:21
@eagleoflqj eagleoflqj requested a review from lotem August 20, 2023 03:21
@eagleoflqj eagleoflqj merged commit 8b7bdbe into rime:master Aug 21, 2023
5 checks passed
@eagleoflqj eagleoflqj deleted the cmake branch August 21, 2023 01:26
groverlynn pushed a commit to groverlynn/librime that referenced this pull request Sep 27, 2023
@eagleoflqj @groverlynn
drop BOOST_USE_CXX11; fix 2 cmake warnings (rime#694)
0ffc56f
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 2, 2023
@eagleoflqj @graphemecluster
drop BOOST_USE_CXX11; fix 2 cmake warnings (rime#694)
8ccafcf
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
@eagleoflqj @graphemecluster
drop BOOST_USE_CXX11; fix 2 cmake warnings (rime#694)
cbde156
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
@eagleoflqj @graphemecluster
drop BOOST_USE_CXX11; fix 2 cmake warnings (rime#694)
5a415b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lotem lotem Awaiting requested review from lotem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@eagleoflqj