Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tools: code page switching for windows #721

Merged
merged 1 commit into from Sep 28, 2023

Conversation

fxliang
Copy link
Contributor

@fxliang fxliang commented Sep 27, 2023

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request
for Windows, SetConsoleOutputCP(CP_UTF8) and restore CP_ACP before exiting.

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

Copy link
Member

@eagleoflqj eagleoflqj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both UTF-8 enabled and unenabled. Confirmed it fixes the latter and doesn't break the former.

@eagleoflqj eagleoflqj merged commit d03a881 into rime:master Sep 28, 2023
8 checks passed
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 2, 2023
@fxliang fxliang deleted the code_page branch November 3, 2023 19:16
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants