Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CleanOldLogFiles doesn't scan cwd when no log_dir #733

Merged
merged 1 commit into from Oct 10, 2023

Conversation

eagleoflqj
Copy link
Member

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@mokapsing
Copy link
Contributor

mokapsing commented Oct 10, 2023

现在正常使用了,但是启动时崩了一次,麻烦看下以下信息是否有用

Redmi/rubens/rubens:13/TP1A.220624.014/V14.0.23.9.18.DEV:user/release-keys
Abort message: 'Check failed: !IsGoogleLoggingInitialized() You called InitGoogleLogging() twice!'

      #00 pc 000000000008cc74  /apex/com.android.runtime/lib64/bionic/libc.so (abort+164) (BuildId: e17f03d82d277eb8d7c51ca3961f4cf9)
      #01 pc 0000000000343250  /data/app/~~cYXF2OLCDCX-63N7lyt4Fw==/org.fcitx.fcitx5.android.plugin.rime-iyjVU0ih55VFrZyTxAPCJA==/lib/arm64/librime.so
      #02 pc 000000000033d9c0  /data/app/~~cYXF2OLCDCX-63N7lyt4Fw==/org.fcitx.fcitx5.android.plugin.rime-iyjVU0ih55VFrZyTxAPCJA==/lib/arm64/librime.so
      #03 pc 000000000033de34  /data/app/~~cYXF2OLCDCX-63N7lyt4Fw==/org.fcitx.fcitx5.android.plugin.rime-iyjVU0ih55VFrZyTxAPCJA==/lib/arm64/librime.so
      #04 pc 000000000033f4e8  /data/app/~~cYXF2OLCDCX-63N7lyt4Fw==/org.fcitx.fcitx5.android.plugin.rime-iyjVU0ih55VFrZyTxAPCJA==/lib/arm64/librime.so
      #05 pc 000000000034308c  /data/app/~~cYXF2OLCDCX-63N7lyt4Fw==/org.fcitx.fcitx5.android.plugin.rime-iyjVU0ih55VFrZyTxAPCJA==/lib/arm64/librime.so
      #06 pc 00000000001c5d58  /data/app/~~cYXF2OLCDCX-63N7lyt4Fw==/org.fcitx.fcitx5.android.plugin.rime-iyjVU0ih55VFrZyTxAPCJA==/lib/arm64/librime.so
      #07 pc 00000000001c6c68  /data/app/~~cYXF2OLCDCX-63N7lyt4Fw==/org.fcitx.fcitx5.android.plugin.rime-iyjVU0ih55VFrZyTxAPCJA==/lib/arm64/librime.so
      #08 pc 00000000001c4598  /data/app/~~cYXF2OLCDCX-63N7lyt4Fw==/org.fcitx.fcitx5.android.plugin.rime-iyjVU0ih55VFrZyTxAPCJA==/lib/arm64/librime.so
      #09 pc 00000000001ca148  /data/app/~~cYXF2OLCDCX-63N7lyt4Fw==/org.fcitx.fcitx5.android.plugin.rime-iyjVU0ih55VFrZyTxAPCJA==/lib/arm64/librime.so
      #10 pc 0000000000097368  /data/app/~~_z-tZHI_uGUQHUHRAky9sQ==/org.fcitx.fcitx5.android-Bq4m9MQfzYUA6d9PEiv8kg==/lib/arm64/libFcitx5Core.so
      #11 pc 0000000000099d1c  /data/app/~~_z-tZHI_uGUQHUHRAky9sQ==/org.fcitx.fcitx5.android-Bq4m9MQfzYUA6d9PEiv8kg==/lib/arm64/libFcitx5Core.so
      #12 pc 0000000000099a58  /data/app/~~_z-tZHI_uGUQHUHRAky9sQ==/org.fcitx.fcitx5.android-Bq4m9MQfzYUA6d9PEiv8kg==/lib/arm64/libFcitx5Core.so
      #13 pc 000000000009949c  /data/app/~~_z-tZHI_uGUQHUHRAky9sQ==/org.fcitx.fcitx5.android-Bq4m9MQfzYUA6d9PEiv8kg==/lib/arm64/libFcitx5Core.so
      #14 pc 0000000000099674  /data/app/~~_z-tZHI_uGUQHUHRAky9sQ==/org.fcitx.fcitx5.android-Bq4m9MQfzYUA6d9PEiv8kg==/lib/arm64/libFcitx5Core.so (fcitx::AddonManager::addon(std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&, bool)+136)
      #15 pc 000000000008329c  /data/app/~~_z-tZHI_uGUQHUHRAky9sQ==/org.fcitx.fcitx5.android-Bq4m9MQfzYUA6d9PEiv8kg==/lib/arm64/libFcitx5Core.so
      #16 pc 00000000000475cc  /data/app/~~_z-tZHI_uGUQHUHRAky9sQ==/org.fcitx.fcitx5.android-Bq4m9MQfzYUA6d9PEiv8kg==/lib/arm64/libFcitx5Utils.so
      #17 pc 0000000000030fc4  /data/app/~~_z-tZHI_uGUQHUHRAky9sQ==/org.fcitx.fcitx5.android-Bq4m9MQfzYUA6d9PEiv8kg==/lib/arm64/libnative-lib.so
      #18 pc 000000000002eebc  /data/app/~~_z-tZHI_uGUQHUHRAky9sQ==/org.fcitx.fcitx5.android-Bq4m9MQfzYUA6d9PEiv8kg==/lib/arm64/libnative-lib.so (event_base_loop+1652)
      #19 pc 000000000021a354  /apex/com.android.art/lib64/libart.so (art_quick_generic_jni_trampoline+148) (BuildId: 1b179f250754dbbf3eaec59393e8b1d6)
      #20 pc 0000000000209398  /apex/com.android.art/lib64/libart.so (nterp_helper+152) (BuildId: 1b179f250754dbbf3eaec59393e8b1d6)
      #21 pc 0000000000298788  /data/app/~~_z-tZHI_uGUQHUHRAky9sQ==/org.fcitx.fcitx5.android-Bq4m9MQfzYUA6d9PEiv8kg==/oat/arm64/base.vdex (org.fcitx.fcitx5.android.core.Fcitx$JNI.loopOnce+0)
      #22 pc 000000000020a254  /apex/com.android.art/lib64/libart.so (nterp_helper+3924) (BuildId: 1b179f250754dbbf3eaec59393e8b1d6)
      #23 pc 000000000029939c  /data/app/~~_z-tZHI_uGUQHUHRAky9sQ==/org.fcitx.fcitx5.android-Bq4m9MQfzYUA6d9PEiv8kg==/oat/arm64/base.vdex (org.fcitx.fcitx5.android.core.Fcitx$dispatcher$1.nativeLoopOnce+8)
      #24 pc 000000000020b074  /apex/com.android.art/lib64/libart.so (nterp_helper+7540) (BuildId: 1b179f250754dbbf3eaec59393e8b1d6)
      #25 pc 000000000029bdac  /data/app/~~_z-tZHI_uGUQHUHRAky9sQ==/org.fcitx.fcitx5.android-Bq4m9MQfzYUA6d9PEiv8kg==/oat/arm64/base.vdex (org.fcitx.fcitx5.android.core.FcitxDispatcher$start$1.invokeSuspend+344)
      #26 pc 0000000002059278  /memfd:jit-cache (deleted) (kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith+200)
      #27 pc 0000000002015734  /memfd:jit-cache (deleted) (kotlinx.coroutin

@eagleoflqj
Copy link
Member Author

Good catch, though irrelevant with this PR 😂️

@eagleoflqj eagleoflqj merged commit eb2477e into rime:master Oct 10, 2023
8 checks passed
@eagleoflqj eagleoflqj deleted the glog-cwd branch October 10, 2023 04:26
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 2, 2023
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants