Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use designated build directory for glog #739

Merged
merged 2 commits into from Oct 16, 2023
Merged

Use designated build directory for glog #739

merged 2 commits into from Oct 16, 2023

Conversation

groverlynn
Copy link
Contributor

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Use designated build directory

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@groverlynn groverlynn changed the title Patch 1 Use designated build directory for glog Oct 15, 2023
@lotem
Copy link
Member

lotem commented Oct 15, 2023 •
edited

Is the original build directory removed?

When did it happen.

eagleoflqj
eagleoflqj approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@eagleoflqj eagleoflqj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lotem The problem is that cmake-build is not a directory ignored by git in glog. Using build is not only uniformed but also cleaner for git status.

@eagleoflqj eagleoflqj merged commit f387307 into rime:master Oct 16, 2023
8 checks passed
@groverlynn groverlynn deleted the patch-1 branch October 17, 2023 06:03
WhiredPlanck pushed a commit to WhiredPlanck/librime that referenced this pull request Oct 18, 2023
@groverlynn @WhiredPlanck
Use designated build directory for glog (rime#739)
f8dce39
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 2, 2023
@groverlynn @graphemecluster
Use designated build directory for glog (rime#739)
60db1f3
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
@groverlynn @graphemecluster
Use designated build directory for glog (rime#739)
f7b1527
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
@groverlynn @graphemecluster
Use designated build directory for glog (rime#739)
04cb367
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
@groverlynn @graphemecluster
Use designated build directory for glog (rime#739)
7984296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eagleoflqj eagleoflqj eagleoflqj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@groverlynn @lotem @eagleoflqj