Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(path): convert to native encoding on Windows #806

Merged
merged 14 commits into from Feb 6, 2024
Merged

fix(path): convert to native encoding on Windows #806

merged 14 commits into from Feb 6, 2024

Commits on Feb 3, 2024

  1. fix(path): convert to native encoding on Windows 

    Follow @fxliang 's PR, use `u8path` on Windows to convert UTF-8 string
to Windows native path.
Closes rime#804

Fixes rime/weasel#576
Fixes rime/weasel#1080

BREAKING CHANGE: `installation.yaml` should be UTF-8 encoded.

Previouly on Windows, the file can be written in local encoding to
enable paths with non-ASCII characters. It should be updated to UTF-8
after this change.
    @lotem
    lotem committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    db7bd40 View commit details
    Browse the repository at this point in the history

  2. avoid path->string->path

    @lotem
    lotem committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    86cd841 View commit details
    Browse the repository at this point in the history

  3. explicitly construct path from string

    @lotem
    lotem committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    5d62d31 View commit details
    Browse the repository at this point in the history

  4. use path instead of string

    @lotem
    lotem committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    02c51a6 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. use path instead of string in mapped_file 

    fix dict_compiler relocate_target: get u8string id from filename
    @lotem
    lotem committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    ca571ad View commit details
    Browse the repository at this point in the history

  2. deployer use paths instead of strings

    @lotem
    lotem committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    16de54c View commit details
    Browse the repository at this point in the history

  3. use path instead string in db

    @lotem
    lotem committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    cfb998f View commit details
    Browse the repository at this point in the history

  4. require explict construction of path objects

    @lotem
    lotem committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    548e385 View commit details
    Browse the repository at this point in the history

  5. overload path::operator/= to encode string oprand 

    simplify code that used to explicitly constrcut path object
    @lotem
    lotem committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    fea3a07 View commit details
    Browse the repository at this point in the history

  6. use path instead of strings in config

    @lotem
    lotem committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    d27a380 View commit details
    Browse the repository at this point in the history

  7. use init-list syntax for path with string literal

    @lotem
    lotem committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    53ef49d View commit details
    Browse the repository at this point in the history

  8. fix DetectModifications args type

    @lotem
    lotem committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    ccaa6c2 View commit details
    Browse the repository at this point in the history

  9. feat(rime_api): secure version of get_*_dir

    @lotem
    lotem committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    39c242d View commit details
    Browse the repository at this point in the history

  10. disable lua plugin 

    it's broken after the change
    @lotem
    lotem committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    028d846 View commit details
    Browse the repository at this point in the history