fix(context): tag selected segment after editing #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
call Context::BeginEditing when input is edited after selection. move cursor also counts as edit. the tag is used to tell if BackSpace should delete the last input character or revert a recent selection. the information was previously denoted by kConfirmed status which caused the side-effect of breaking a user phrase into individual segments. fixed rime#746, fixed rime#830
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
call Context::BeginEditing when input is edited after selection. move cursor also counts as edit.
the tag is used to tell if BackSpace should delete the last input character or revert a recent selection.
the information was previously denoted by kConfirmed status which caused the side-effect of breaking a user phrase into individual segments.
fixed #746, fixed #830