Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins): load plugins in relative path #833

Merged
merged 3 commits into from Mar 6, 2024
Merged

Conversation

lotem
Copy link
Member

@lotem lotem commented Mar 3, 2024

in cmake config set RIME_PLUGINS_DIR as relative to libdir

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

plugins/CMakeLists.txt Outdated Show resolved Hide resolved
@lotem lotem force-pushed the plugins branch 3 times, most recently from 01cfdc0 to b588c6f Compare March 5, 2024 09:28
@fxliang
Copy link
Contributor

fxliang commented Mar 6, 2024

LGTM

@lotem lotem merged commit 3019e5f into rime:master Mar 6, 2024
9 checks passed
@lotem lotem deleted the plugins branch March 6, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants