Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add large address aware for msvc build #843

Merged
merged 1 commit into from Mar 10, 2024
Merged

add large address aware for msvc build #843

merged 1 commit into from Mar 10, 2024

Conversation

fxliang
Copy link
Contributor

@fxliang fxliang commented Mar 9, 2024

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

32 bit dll by msvc could access up to 4GB memory in 64 bit windows.

rime_deployer(32bit) deployment test pass (kongmingmabig)

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

Copy link
Member

@lotem lotem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix indentation.

CMakeLists.txt Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants