Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add English resource info for mingw/clang build. #847

Merged
merged 2 commits into from Mar 17, 2024

Conversation

fxliang
Copy link
Contributor

@fxliang fxliang commented Mar 12, 2024

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request
nightly build clang output
image
release build librime.dll
image

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@fxliang fxliang changed the title build: add English resource info for mingw/clang build. build: add English resource info for mingw/clang build.[WIP] Mar 12, 2024
@fxliang fxliang changed the title build: add English resource info for mingw/clang build.[WIP] build: add English resource info for mingw/clang build. Mar 12, 2024
@fxliang fxliang force-pushed the resinfo_mingw_clang branch 3 times, most recently from 2c253fd to 6f7cc4c Compare March 12, 2024 06:00
cmake/AddRCInfo.cmake Outdated Show resolved Hide resolved
cmake/AddRCInfo.cmake Show resolved Hide resolved
@lotem lotem merged commit 09da263 into rime:master Mar 17, 2024
10 checks passed
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants