Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reverse lookup of words #80

Closed
wants to merge 1 commit into from
Closed

Fix reverse lookup of words #80

wants to merge 1 commit into from

Conversation

ayaka14732
Copy link
Collaborator

Currently, when using Putonghua pinyin (普通話拼音) to reverse lookup ni (你), there is a comment of its Cantonese pronunciation nei5. However, for words over one characters, like ni hao (你好), there is no comment of its Cantonese pronunciation. This is a known issue of librime: rime/home#500.

This pull request proposes a method that enables words over one characters to have comments when doing the reverse lookup by creating a new dictionary called jyut6ping3_unspaced. The file is automatically generated from jyut6ping3 by running the Python script tools/build_unspaced.py. The difference is that all the spaces are replaced by equal signs (=).

The drawback of this method is that the dictionary will be stored twice in the repository. However, considering the benefits it provides, this change can be quite worthwhile.

@tanxpyox
Copy link
Collaborator

LGTM! - but if it makes the installer too big, I think a better way of doing it is incorporating the builder script to the CI workflow, so that we can keep this unspaced branch updated and usable as an optional module.

@laubonghaudoi laubonghaudoi added the enhancement New feature or request label Jul 30, 2020
@LEOYoon-Tsaw
Copy link
Member

I'd really hope that someone fix it in librime rather than creating a duplicated dictionary for length>1 words. But I have to admit this works for now.

Copy link
Member

@laubonghaudoi laubonghaudoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前有conflict,跟進更新之後就可以合併落master嘞

@tanxpyox
Copy link
Collaborator

合併落master嘞

我都係覺得將呢個功能分開做另一個branch好啲——如果唔係個安裝包會有成40MB.... 加上已經寫好晒自動生成嘅script,應該可以用 Github Actions 實裝 (trigger on commit)

@laubonghaudoi
Copy link
Member

如果係噉嘅話,噉安裝教程嗰度要加多一個部分教點樣裝呢個branch

@laubonghaudoi
Copy link
Member

@ayaka14732 我係唔係可以先閂咗呢個 PR?

@laubonghaudoi laubonghaudoi deleted the unspaced branch September 12, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants