Fix wrap-ssl-redirect calling handler on redirect

[mainej]

Commit a495828 introduced a bug in which the handler passed to
wrap-ssl-redirect was always called, regardless of whether the request
was over SSL. This is a bit like launching the missles, then saying "I'm
sorry I can't launch, you have the wrong code."

This bug wasn't caught by the tests because, until now none of them
checked whether the inner handler is called.

[weavejester]

Thanks for the fix!

Could you possibly add a docstring to ssl-redirect, perhaps something like:

  "Given a HTTP request, return a redirect response to the equivalent HTTPS URL.
  See: wrap-ssl-redirect."

Also, could you change the commit message to:

Fix wrap-ssl-redirect calling handler on redirect

Handler should not be called when a redirect response is returned.

This explains the issue more concisely, and sticks to imperative mood in the summary line.

[weavejester]

Indentation needs fixing, here?

[mainej]

Yep, good suggestions. I'll push those changes shortly.

Also, should the ssl-redirect function be named ssl-redirect-response? I'm not sure of the convention here. And finally, should the shared conditional be extracted, something like ssl-request?

Thanks for writing and maintaining so many useful Clojure libraries!

[weavejester]

The convention I'm using is that if I have a middleware function wrap-foo, then the "request" part of it should be handled by a function foo-request, and the response part handled by foo-response.

In this case it only makes sense to call the response part if the request is HTTP, so... yes, on reflection I think ssl-redirect should be renamed to ssl-redirect-response.

[mainej]

ssl-redirect renamed to ssl-redirect-response