Charset on non-text content types (Internet Explorer)

[kirasystems]

The current behaviour of the jetty adapter is to set charset=UTF-8 on every response. It turns out that doing this on image responses when HTTPS is being used causes IE7/8 (I think 9 as well, though didn't verify) to sporadically not display images (or very consistently in the case of IE7).

My temporary solution to this was to disable the charset in ring-jetty-adapter and instead use the following middleware:

(defn wrap-utf8
    "Wrap UTF-8 encoding only on text responses."
    [handler]
    (fn [req]
        (let [resp  (handler req)
              ctype (get-in resp [:headers "Content-Type"])]
                (if (and (> (count ctype) 5) (= (subs ctype 0 5) "text/" ))
                    (charset resp "UTF-8")
                    resp))))

[weavejester]

In Ring 1.1.6 I've disabled any default charsets. Compojure and Noir supply their own charsets anyway for text/html responses, and Ring shouldn't be setting defaults in this case, I think.