Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jetty.clj #229

Closed
wants to merge 1 commit into from
Closed

Update jetty.clj #229

wants to merge 1 commit into from

Conversation

sdegutis
Copy link
Contributor

No description provided.

@weavejester
Copy link
Member

Thanks for the patch. However, you'll need to change the commit message and PR description to be more explanatory. As it stands, you have no description of what you're doing, and the commit message just tells me what file you're changing. Instead, consider something like:

Refactor run-jetty function for clarity

You also need to make sure your indentation is correct, and it might be better to drop the doto altogether:

  (let [server (create-server (dissoc options :configurator))]
    (.setHandler server (proxy-handler handler))
    (when-let [configurator (:configurator options)]
      (configurator server))

@weavejester weavejester closed this Jun 4, 2017
weavejester added a commit that referenced this pull request Jul 15, 2017
Default timeout to zero and ignore Jetty default of 30 seconds. Most of
the time we want to manage timeouts ourselves, so the AsyncContext
timeout should be disabled (zero) by default.

Fixes #229.
weavejester added a commit that referenced this pull request Jul 15, 2017
Default timeout to zero and ignore Jetty default of 30 seconds. Most of
the time we want to manage timeouts ourselves, so the AsyncContext
timeout should be disabled (zero) by default.

Fixes #229.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants