ProvideBuffers API for buffer preregistration #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Drive API is extended with two associated types - the read buffer and the write buffer types - which both must implement a trait called `ProvideBuffer`. This trait abstracts the notion of providing a buffer for IO to be preformed in. A simple `HeapBuffer` type is provided, which provides a buffer by allocating it into the heap. However, a more advanced implementation of a driver could instead implement these traits to make use of io-uring's buffer preregistration facilities, cycling preregistered buffers through a buffer pool behind these APIs. More experimentation is needed to prove out these APIs as actually sufficient for implementing the desired behavior against io-uring's existing APIs. Closes #2
the write side of it previous was wrong and wouldn't work with non-heapbuffer interfaces
withoutboats
force-pushed
the
provide-buffers
branch
from
2c9038e
to
0d510b9
Compare
Open
|
Closing as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Drive API is extended with two associated types - the read buffer and the write buffer types - which both must implement a trait called
ProvideBuffer. This trait abstracts the notion of providing a buffer for IO to be preformed in.Three buffer types are provided:
HeapBuffer, which is a simple heap allocated bufferRegisteredBuffer, which a buffer that has been preregistered with io_uring_registerGroupRegisteredBuffer, (only valid as a read buffer), which uses the automatic buffer selection group registration APIBoth of the latter two APIs require the underlying drive handle to implement additional extension to support their operation.
Closes #2