Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMS Post with attachment returns FaxResponse #31

Closed
rjgeorge opened this issue Apr 28, 2018 · 2 comments
Closed

SMS Post with attachment returns FaxResponse #31

rjgeorge opened this issue Apr 28, 2018 · 2 comments

Comments

@rjgeorge
Copy link

Passing attachments to the extension.Sms().Post method call returns a FaxResponse. When calling Post without passing attachments the return value is GetMessageInfoResponse. Is this by design or a bug?

var attachment1 = new Attachment { fileName = "attachment.jpg", contentType = "image/jpg", bytes = Convert.FromBase64String(base64Image) };
var attachments = new Attachment[] { attachment1 };
var response = await extension.Sms().Post(new
  {
         to = new CallerInfo[] { new CallerInfo { phoneNumber = telephoneNumber } },
         from = new CallerInfo { phoneNumber = RingCentralConfig.Instance.username },
         text = messageText
  }, attachments);
@tylerlong
Copy link
Collaborator

tylerlong commented May 20, 2018

It is a bug.

SMS with attachments is MMS which is similar to Fax. So when I did the implementation I copied some code from Fax.

I will fix it.

@tylerlong
Copy link
Collaborator

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants