Optional urlPrefix and apiVersion for Platform.createUrl.

[MostFrumiousBandersnatch]

This is how we're about to utilize it:

 sdk().platform().createUrl(
       this.getRawURI(args),
       {
             addToken: true,
             addServer: true
             urlPrefix: '/rcvideo',
             apiVersion: 'v1'
       }
)

[coveralls]

Coverage increased (+0.04%) to 91.285% when pulling 7da77f0 on MostFrumiousBandersnatch:master into 23c96e0 on ringcentral:master.

[coveralls]

Coverage increased (+0.04%) to 91.285% when pulling 7da77f0 on MostFrumiousBandersnatch:master into 23c96e0 on ringcentral:master.

[coveralls]

Coverage increased (+0.05%) to 91.3% when pulling ad08cdf on MostFrumiousBandersnatch:master into 23c96e0 on ringcentral:master.

[kirill-konshin]

The better idea would be to just add something like knownPrefixes property because otherwise you will have to manually run createUrl for any request that you send. Not convenient...

[MostFrumiousBandersnatch]

Not sure, that it would a better idea.

Thus, we would initialize the SDK object with some knownPrefixes and, then call createUrl pointing one of them? How? Implicitly, by number? Either explicitly, and face with possible rejections when given values aren't ones among predefined knownPrefixes?
That's a responsibility of higher-level code, to provide a necessary abstraction around createUrl. The SDK itself hardly should be concerned about that.
Nothing would prevent us from wrapping createUrl into few different functions, specifying different options in each one.

[kirill-konshin]

The idea is that if createUrl that is called by get|post|put|delete (with no params) will see the prefix it will not do anything with the URL. We can add knownPrefixes array in Platform class AND an escape latch in SDK constructor to override/append to that array if needed.

I don't think there will be too many prefixes and that they will appear very frequently.

We should not force customers to figure out what function to call to format URL correctly: in my opinion, platform.get(platform.createUrl(...), {things}) is not very user friendly.

[MostFrumiousBandersnatch]

I decided to neglect the merging predefined knownPrefixes with passed knownPrefixes, in order to keep code base small (avoiding extra dependencies). Let me know if it's (necessity of merge) really a case.

[kirill-konshin]

Weird code style to add a slash between two strings )

[MostFrumiousBandersnatch]

It's just more efficient than string concatenation. Anyway, i can replace it.

[kirill-konshin]

That's OK.

[kirill-konshin]

All good. Please bump minor version, make a build and update this PR. Also please figure out what's wrong with failed CI on Node 4, maybe we should kick it out of stack.

[MostFrumiousBandersnatch]

I have no idea why it fails just on Node 4, being run in Travis. Error seems to be irrelevant to node version, furthermore it run normally on my machine, using the very same version of node.
Anyway brief investigation of the issue reveals something:

Subscription-spec.js

return subscription.setEventFilters(['foo', 'bar'])

Subscription.js

Subscription.prototype._getFullEventFilters = function() {
    return this.eventFilters().map(function(event) {
        return this._platform.createUrl(event);
    }.bind(this));
}

which generates suspicious URLs:

> sdk.platform().createUrl('foo');
'/restapi/v1.0foo

Hope, that may give you a hint to fix that issue.

[kirill-konshin]

Remove Node 4 from travis.yml

[MostFrumiousBandersnatch]

Are you sure to remove it? Version of node is hardly a reason, assuming results of recent build .