Merge 8a70782 into 512282e

packages/testring-recorder-backend/test/http-server.functional.spec.ts

@@ -4,20 +4,29 @@ import * as path from 'path';
 import * as fs from 'fs';
 import * as chai from 'chai';
 import * as request from 'request-promise';
+
+import { getAvailablePort } from '@testring/test-utils';
+
 import { RecorderHttpServer } from '../src/http-server';
 
 const index = fs.readFileSync(
     path.resolve(__dirname, './fixtures/templates/index.hbs'),
     { encoding: 'utf8' }
 );
 
+let httpPort = 8080;
+
 describe('Recorder HTTP server', () => {
+    beforeEach(async () => {
+        httpPort = await getAvailablePort(httpPort);
+    });
+
     it('should serve over HTTP until it stopped', (callback) => {
         const server = new RecorderHttpServer(
             path.resolve(__dirname, './fixtures/static'),
             path.resolve(__dirname, './fixtures/templates'),
             'localhost',
-            8080
+            httpPort
         );
 
         server.run().then(() => {

packages/testring-recorder-backend/test/recorder-server.functional.spec.ts

@@ -1,27 +1,34 @@
 import * as request from 'request-promise';
 import * as WebSocket from 'ws';
 import * as chai from 'chai';
+import { getAvailablePort } from '@testring/test-utils';
 
 import { TransportMock } from '@testring/test-utils';
 import { RecorderServerEvents, RecorderServerMessageTypes } from '@testring/types';
 
 import { RecorderServer } from '../src/recorder-server';
 import { DEFAULT_HOST, DEFAULT_HTTP_PORT, DEFAULT_WS_PORT } from '../src/constants';
 
-const httpUrl = `http://${DEFAULT_HOST}:${DEFAULT_HTTP_PORT}`;
-const wsUrl = `ws://${DEFAULT_HOST}:${DEFAULT_WS_PORT}`;
-
 describe('Recorder server', () => {
     let srv: RecorderServer;
     let transport: TransportMock;
+    let httpPort = DEFAULT_HTTP_PORT;
+    let httpUrl = `http://${DEFAULT_HOST}:${DEFAULT_HTTP_PORT}`;
+    let wsPort = DEFAULT_WS_PORT;
+    let wsUrl = `ws://${DEFAULT_HOST}:${DEFAULT_WS_PORT}`;
 
     beforeEach(async () => {
         transport = new TransportMock();
 
+        httpPort = await getAvailablePort(DEFAULT_HTTP_PORT);
+        httpUrl = `http://${DEFAULT_HOST}:${httpPort}`;
+        wsPort = await getAvailablePort(DEFAULT_WS_PORT, [httpPort]);
+        wsUrl = `ws://${DEFAULT_HOST}:${wsPort}`;
+
         srv = new RecorderServer(
             DEFAULT_HOST,
-            DEFAULT_HTTP_PORT,
-            DEFAULT_WS_PORT,
+            httpPort,
+            wsPort,
             transport,
         );
 

packages/testring-recorder-backend/test/ws-server.functional.spec.ts

@@ -1,11 +1,18 @@
 import * as WebSocket from 'ws';
 import * as chai from 'chai';
+import { getAvailablePort } from '@testring/test-utils';
 
 import { RecorderWebSocketServer, RecorderWsEvents } from '../src/ws-server';
 
 describe('Recorder WebsSocket server', () => {
+    let port = 8080;
+
+    beforeEach(async () => {
+        port = await getAvailablePort(port);
+    });
+
     it('should start ws server and emit event of connections', (callback) => {
-        const server = new RecorderWebSocketServer('localhost', 8080);
+        const server = new RecorderWebSocketServer('localhost', port);
 
         server.run().then(() => {
             server.on(RecorderWsEvents.CONNECTION, (ws) => {
@@ -16,7 +23,7 @@ describe('Recorder WebsSocket server', () => {
                 callback();
             });
 
-            new WebSocket('ws://localhost:8080');
+            new WebSocket(`ws://localhost:${port}`);
         });
     });
 });

packages/testring-test-utils/src/get-available-port.ts

@@ -0,0 +1,19 @@
+import { createServer } from 'net';
+
+export const getAvailablePort = (port: number, skip: Array<number> = []): Promise<number> => {
+    return new Promise((async (resolve) => {
+        if (skip.includes(port)) {
+            resolve(await getAvailablePort(port + 1, skip));
+        }
+
+        const testConnection = createServer();
+
+        testConnection.once('error', async () => {
+            resolve(await getAvailablePort(port + 1, skip));
+        }).once('listening', () => {
+            testConnection.once('close', () => {
+                resolve(port);
+            }).close();
+        }).listen(port);
+    }));
+};

packages/testring-test-utils/src/index.ts

@@ -1,3 +1,4 @@
 export { TransportMock } from './transport.mock';
 export { TestWorkerMock } from './test-worker.mock';
 export { BrowserProxyControllerMock } from './browser-proxy-controller.mock';
+export { getAvailablePort } from './get-available-port';