websocket broken

[oberhamsi]

I get exception when I try to open the connection. Code: https://github.com/oberhamsi/websocket-ringojs/blob/master/main.js

21827 [qtp589411738-22] WARN  org.eclipse.jetty.servlet.ServletHandler  - /ringo-chat
org.mozilla.javascript.WrappedException: Wrapped java.lang.RuntimeException: No worker associated with current thread (ringo/httpserver.js#221)
at org.mozilla.javascript.Context.throwAsScriptRuntimeEx(Context.java:1786)
at org.mozilla.javascript.MemberBox.invoke(MemberBox.java:183)
at org.mozilla.javascript.FunctionObject.call(FunctionObject.java:476)
at org.mozilla.javascript.BoundFunction.call(BoundFunction.java:83)
at org.mozilla.javascript.optimizer.OptRuntime.call2(OptRuntime.java:76)
at org.mozilla.javascript.gen.ringo_httpserver_js_27._c_anonymous_8(ringo/httpserver.js:221)
at org.mozilla.javascript.gen.ringo_httpserver_js_27.call(ringo/httpserver.js)
at org.mozilla.javascript.ContextFactory.doTopCall(ContextFactory.java:426)
at org.mozilla.javascript.ScriptRuntime.doTopCall(ScriptRuntime.java:3178)
at org.mozilla.javascript.gen.ringo_httpserver_js_27.call(ringo/httpserver.js)
at org.mozilla.javascript.JavaAdapter.doCall(JavaAdapter.java:598)
at org.mozilla.javascript.JavaAdapter.access$000(JavaAdapter.java:54)
at org.mozilla.javascript.JavaAdapter$1.run(JavaAdapter.java:578)
at org.mozilla.javascript.Context.call(Context.java:521)
at org.mozilla.javascript.ContextFactory.call(ContextFactory.java:535)
at org.mozilla.javascript.JavaAdapter.callMethod(JavaAdapter.java:575)
at adapter1.doWebSocketConnect(<adapter>)
at org.eclipse.jetty.websocket.WebSocketFactory.acceptWebSocket(WebSocketFactory.java:310)
at org.eclipse.jetty.websocket.WebSocketServlet.service(WebSocketServlet.java:78)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:547)
at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:480)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:119)
at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:520)
at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:227)
at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:941)
at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:409)
at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:186)
at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:875)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:117)
at org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:250)
at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:149)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:110)
at org.eclipse.jetty.server.Server.handle(Server.java:349)
at org.eclipse.jetty.server.HttpConnection.handleRequest(HttpConnection.java:441)
at org.eclipse.jetty.server.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:919)
at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:582)
at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:218)
at org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:51)
at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:586)
at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:44)
at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:598)
at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:533)
at java.lang.Thread.run(Thread.java:662)
Caused by: java.lang.RuntimeException: No worker associated with current thread
at org.ringojs.engine.RhinoEngine.getCurrentWorker(RhinoEngine.java:246)
at org.ringojs.wrappers.EventAdapter$Callback.<init>(EventAdapter.java:370)
at org.ringojs.wrappers.EventAdapter.addListener(EventAdapter.java:119)
at org.ringojs.wrappers.EventAdapter.addListener(EventAdapter.java:100)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.mozilla.javascript.MemberBox.invoke(MemberBox.java:161)
... 42 more

[aaditmshah]

I encountered the same problem. Correct me if I'm wrong but I think that the latest release of Ringo expects that each Java thread has its own worker. Each instance of WebSocket is a JavaEventEmitter mixin. It creates a new Java object which implements org.eclipse.jetty.websocket.WebSocket.OnTextMessage and returns it to the WebSocketServlet instance which dispatches the open, message, and close events on the Java object. If I'm not mistaken then the event handlers are executed on a separate thread. However since it doesn't have any worker associated with it Rhino throws an exception.

[oberhamsi]

Hannes mentioned he will rewrite the Worker implementation so I did not investigate further.

I just put this issue up so everyone knows it's a known problem :)

[hns]

Still needs to be fixed. This must be a regression with one of the last commits. Also reproducible with examples/websocket-echo.js