Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to jline3 #413

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Upgrade to jline3 #413

merged 1 commit into from
Dec 11, 2020

Conversation

grob
Copy link
Member

@grob grob commented Nov 16, 2020

This upgrades the RingoJS shell to jline3, with main improvements:

  • multiline editing and history entries
  • colored code completion candidates

Unfortunately I couldn't test this change on Windows, maybe someone else would jump in?

main improvements:
- multiline editing and history entries
- colored code completion candidates
@botic botic added this to the 3.0.0 milestone Dec 11, 2020
@botic
Copy link
Member

botic commented Dec 11, 2020

I have no Windows machine around, but would merge anyway and fix potential issues later. Any objections, @grob?

@botic botic added the java label Dec 11, 2020
@grob
Copy link
Member Author

grob commented Dec 11, 2020

No. Go ahead, we'll see if this breaks anything on Windows.

@botic botic merged commit c2c0d19 into ringo:master Dec 11, 2020
@grob grob deleted the jline3 branch December 12, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants