New ringo-admin #435
Merged
New ringo-admin #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringo-admin install is now capable to install packages by url (tar/zip archives or git repositories)
it requires a confirmation before creating the application directory, and resolves app skeleton dependencies
… both <owner>/<repo> and full https urls
zip archive without a base path returned ".", while tar archives returned an empty string
both create and install commands now support `help <command>`, `<command> -h` and `<command> --help`
they are still logged into <ringo-home>.ringo-admin.log, but don't pollute the test console output
…into the local package.json
…these will be logged into .ringo-admin.log anyway)
git+file is only used to distinguish between archive and repository file urls
…used composeUrl method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#434 Improves ringo-admin
installcommand:<github owner>/<github repo>)http(s)scheme only)git,git+ssh,ssh,git+http(s)andgit+fileschemes plus GitHub URLs (this is usinggitvia Java'sProcessBuilder, so naturally git has to be installed and contained inPATH)tree-ishoption as URL hash (i.e.https://github.com/ringo/ringojs#ringo-admin) to clone/checkout a specific branch, tag or commit. Repositories are copied into the packages directory without.gitdirectory.-n/--no-depsis specifiedpackagesdirectory beneath the current one, the closest parent directory containing apackage.jsonfile, or in the "global" ringo packages directory (-g/--global)-s/--save)The functionality of the
createcommand hasn't changed, but the app skeleton has been modernized to usestickandreinhardtpackages (see #359). Note that it's currently using stick v1.0 branch resp. reinhardt's es6 branch, which should probably change once these branches are released.Both commands log fairly verbose into
<ringo-home>/.ringo-admin.log.Overall ringo-admin has a cleaner structure now, which should ease adding additional commands in the future
Please note that this has only been tested on my local mac. There are some unit tests covering the most basic (and important) methods, but i'm still trying to find a sane way of producing integration tests.