Shell autocompletion/suggestion fixes #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autocompletion/suggestion didn't work for method call arguments:
```
const obj = {one: {two: {three: 3}}}
JSON.stringify(obj.o<tab>
```
didn't expand to `JSON.stringify(obj.one` because the candidates produced didn't start with `JSON.stringify(`, so they were dropped by jline.
this change also fixes highlighting of candidate prefixes: before only the typed characters were highlighted, now ringo shell highlights up to the next completion point (if any).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shell autocompletion stopped working in certain cases, eg. for method call arguments:
didn't expand to
JSON.stringify(obj.onebecause the candidate produced contained onlyobj.one, notJSON.stringify(obj.one.This pull request also fixes highlighting up to the next possible completion point (before only the typed characters were highlighted), and it updates jline to version 3.20.0