build: don't call cargo from build.rs #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you really want to ensure that the code is correctly formatted you can configure your editor to run the format command on-save (most editor can do this with LSP) and/or add a GitHub action that check that the code is correctly formatted before the merge (I can give you a snippet if needed 🙂) |
ringsaturn
reviewed
Mar 13, 2024
|
I agree that fmt should not runned when build, I’ll move that to CI. |
This doesn't work when building outside of Cargo (e.g. using Bazel that invoke rustc directly).
grim7reaper
force-pushed
the
do-not-call-cargo-during-build
branch
from
8a1a2e0
to
9235e46
Compare
ringsaturn
approved these changes
Mar 13, 2024
|
Released in 0.4.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't work when building outside of Cargo (e.g. using Bazel that invoke rustc directly).