This repository has been archived by the owner on Jan 23, 2022. It is now read-only.
Command server and invoker #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmalloc
suggested changes
Mar 24, 2017
src/Internal/Command/Invoker.php
Outdated
| use Rinq\Context; | ||
| use Rinq\Ident\MessageId; | ||
| use Rinq\Ident\PeerId; | ||
| use Rinq\Payload; |
There was a problem hiding this comment.
This payload keeps coming back :P Payloads will just be a mixed type variable.
src/Internal/Command/Server.php
Outdated
|
|
||
| namespace Rinq\Internal\Command; | ||
|
|
||
| use Rinq\CommandHandler; |
There was a problem hiding this comment.
I think you decided to just use callable for handlers (?)
src/Internal/Service/Service.php
Outdated
| /** | ||
| * Service is an interface for background tasks that can finish with an error. | ||
| */ | ||
| interface Service |
There was a problem hiding this comment.
I don't know yet, but I don't think this interface will be necessary in PHP.
In Go it's used to wait for several sub-systems that are running in separate threads.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.