Add endpoint currently playing #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This relates to #10 |
rinukkusu
requested changes
Dec 6, 2018
WesleyBatista
force-pushed
the
add_endpoint_currently_playing
branch
from
5bc2533
to
9b7361b
Compare
WesleyBatista
force-pushed
the
add_endpoint_currently_playing
branch
from
9b7361b
to
0fa1421
Compare
rinukkusu
approved these changes
Dec 17, 2018
|
How does the package gets updated on here: https://pub.dartlang.org/packages/spotify#-versions-tab- Is something that you run locally, I suppose? |
|
Yes, exactly. I need to make a publish to pub - will do that later on. |
|
@WesleyBatista I've just published the new version with your changes! 馃帀 |
|
That's awesome! Thanks 馃槃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't managed to test for real (building an application or whatever), but the test is working.
Congrats for nice package and how you designed it! 馃憦 馃憦 馃憦
Really straight forward to contribute without any Dart background.