Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

see issue #22 #29

Merged
merged 2 commits into from
Feb 11, 2020
Merged

see issue #22 #29

merged 2 commits into from
Feb 11, 2020

Conversation

hayribakici
Copy link
Collaborator

@hayribakici hayribakici commented Feb 11, 2020 •
edited

  • propagates SpotifyException when dealing with BundledPage response
  • allows error provocation when using unit test

@hayribakici
see issue rinukkusu#22
6e855b7 
- propagates `SpotifyException` when dealing with `BundledPage` response
- allows error provocation when using unti test
@hayribakici
see rinukkusu#22
c301b41 
- adds more test asserts
rinukkusu
rinukkusu approved these changes Feb 11, 2020
View reviewed changes
Copy link
Owner

@rinukkusu rinukkusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rinukkusu rinukkusu merged commit 36e7bf9 into rinukkusu:master Feb 11, 2020
@hayribakici hayribakici deleted the fix_#22 branch February 11, 2020 22:10
@hayribakici hayribakici mentioned this pull request Feb 17, 2020
Closed
@Loopex2019 Loopex2019 mentioned this pull request May 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinukkusu rinukkusu rinukkusu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hayribakici @rinukkusu