Devices API #36
Merged
Devices API #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds new Device class for storing user's visible devices information
rinukkusu
reviewed
Mar 30, 2020
|
@rinukkusu please don't merge, yet until tests are through. See #37. Thank you. |
Closed
- Example uses Spotifiy's Authorization Code flow to access user specific data - Only calling currentlyPlaying and available devices Api - Authorization code flow is done quite primitively by requesting user to call url and past the redirect url back to the terminal - allows to properly propagate error object when request fails
…to spotify_devices
LeviHassel
reviewed
Apr 7, 2020
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to get a list of available devices.
In order to properly test the API I extended the
example.dartfile to allow access user specific data with Spotify's authorization code flow. This is done quite primitively by requesting the user to call an url and paste the redirect url back to the terminal. Currenly onlycurrentlyPlaying()anddevices()are called.The
devices()method now properly propagates an error object when the request fails.Also, each time this file gets run with
pub runthe authorization code flow needs to be redone. I am not sure if that is a security issue when running this file many times.Thank you for @LeviHassel and @roisnir for the solutions and help.