Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new authorization details to README #41

Merged
merged 7 commits into from
Apr 21, 2020

Conversation

LeviHassel
Copy link
Collaborator

This PR adds more details about Spotify authorization to the README based on the discussion in #37.

I've personally used every approach I mentioned for Flutter, but I'd appreciate any thoughts from @rinukkusu and @roisnir on how to better explain the Authorization Code Flow for a Dart app.

@LeviHassel LeviHassel mentioned this pull request Apr 4, 2020
README.md Outdated Show resolved Hide resolved
@roisnir
Copy link
Collaborator

roisnir commented Apr 5, 2020

This PR adds more details about Spotify authorization to the README based on the discussion in #37.

I've personally used every approach I mentioned for Flutter, but I'd appreciate any thoughts from @rinukkusu and @roisnir on how to better explain the Authorization Code Flow for a Dart app.

First, this documentation is great and definitely going to help users thank you!

Unfortunately, I haven't written such dart app too, and I have no good idea for production apps but here are some workarounds ideas.
If the case is testing an api request in an example file of a flutter app (like @hayribakici described here) or any other command-line dart application. You can launch the authorization URL in a web browser (see this thread) or print and paste to the browser. Sign in, and then, when redirected copy the redirect URL with the authorization code and paste to the app's input (with stdin.readLineSync())

In the case of an HTTP server, I can't think of a way to authorize because it requires user interface for the user to authenticate.

@LeviHassel
Copy link
Collaborator Author

@roisnir thanks for the ideas! I think the command-line approach you described would be a much quicker solution for @hayribakici than what I suggested here.

@LeviHassel
Copy link
Collaborator Author

I just updated the PR with code snippets for the url_launcher/uni_links approach and the WebView approach @roisnir mentioned. I also hid all of the imaginary function explanations inside an expandable/collapsible section so that it doesn't detract from all of the other good advice in the README. 😄

@rinukkusu
Copy link
Owner

Thanks for the great efforts you put into making this documentation better for everyone!

@rinukkusu rinukkusu merged commit 7eaf908 into rinukkusu:master Apr 21, 2020
@LeviHassel LeviHassel deleted the improve-readme branch April 25, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants