Add Search Endpoint #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayribakici
commented
Nov 10, 2018
| }, onResume: () { | ||
| _bufferedPages.forEach(stream.add); | ||
| if (_bufferedPages.last.isLast) { | ||
| stream.close(); |
There was a problem hiding this comment.
just added some formatting here.
added 2 commits
November 11, 2018 02:48
rinukkusu
requested changes
Nov 12, 2018
There was a problem hiding this comment.
Hey @hayribakici,
thanks for you contribution - looks pretty good overall. I've added some comments here and there, please check them out!
added 3 commits
November 12, 2018 12:41
- Changes parser types for search result
|
@rinukkusu hi, I cleaned up the code. Now the I thought to add this comment to clarify potential confusion, because the PR diff is quite messy. |
chances
suggested changes
Nov 20, 2018
- renames method
rinukkusu
approved these changes
Nov 21, 2018
|
LGTM Thank you for contributing this new endpoint! 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt to add a search endpoint into this library. This is not a final stage, rather a discussion about the approach and maybe how it can be improved. Basically, this is the solution I came up with by giving the
Pagesclass aMapofParserFunctions (instead of only one) to enable distinguishing the different paging json objects in the search result.