Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO 639-1 Language codes #85

Closed
drdrak3 opened this issue Jun 28, 2018 · 2 comments
Closed

ISO 639-1 Language codes #85

drdrak3 opened this issue Jun 28, 2018 · 2 comments

Comments

@drdrak3
Copy link

drdrak3 commented Jun 28, 2018

Any chance of implementing ISO 639-1 codes instead of ISO 639-2 codes?
PHP plays better with ISO 639-1 codes: http://php.net/manual/en/locale.getdisplaylanguage.php

At the moment I'm resorting to a helper class just to convert ISO 639-2 to ISO 639-1.

$languages = [
    ['ab', 'abk'],
    ['aa', 'aar'],
    ['af', 'afr'],
    ['ak', 'aka'],
    ['sq', 'sqi'],
    ...
];
@drdrak3 drdrak3 changed the title Language codes ISO 639-1 Language codes Jun 28, 2018
@Omranic
Copy link
Member

Omranic commented Dec 22, 2018

That's very good point, if you can help with PR that would be much appreciated ^_^

@Omranic
Copy link
Member

Omranic commented Oct 2, 2021

I gave it a try, but this is more complicated than I thought, it requires breaking changes, and changing how the country languages and translations are handled.

Tak Afghanistan as an example, when you check it's native name, you'll find it available in three language dialects: prs, pus, and tuk. Both prs and pus belongs to the same fa language. Then what should we do in that case?

There's some options we can do here, but all as I see require doing breaking changes, and changing how we handle languages and translations.

Still, I'll be happy to consider PRs, all PRs are welcome 😉

@Omranic Omranic closed this as completed Oct 2, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants