Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added type hinting for array type arguments #28

Closed

Conversation

marianoasselborn
Copy link

@marianoasselborn marianoasselborn commented Oct 6, 2016

Hi, thanks for your work man, it's awesome!

As these methods do not accept $attributes in any other type than an array, I put some type hints on them :)

@Omranic
Copy link
Member

Omranic commented Oct 9, 2016

Thanks @marianoasselborn for your contribution, that's really appreciated.
But please note that develop branch is currently under heavy development which has been re-written from scratch & things has changed a lot, so next release won't be 1.x, instead it will be 2.x, which don't have these methods anyway. Please check the develop branch & feel free to send any fixes or PRs there, thanks again 👍

@Omranic Omranic closed this Oct 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants