Skip to content
This repository has been archived by the owner on Feb 16, 2022. It is now read-only.

resolve conflict versions #159

Closed
wants to merge 1 commit into from
Closed

Conversation

onjiz
Copy link

@onjiz onjiz commented Jun 17, 2021

No description provided.

@codeclimate
Copy link

codeclimate bot commented Jun 17, 2021

Code Climate has analyzed commit 12b723b and detected 0 issues on this pull request.

View more on Code Climate.

@Omranic
Copy link
Member

Omranic commented Jul 3, 2021

Thank you @onjiz for the PR.

Currently this package is undergoing a complete rewrite, removing the jeremeamia/superclosure & opis/closure dependency completely, and simplifying the code a lot, but I'm still not happy with the overall performance (I believe we can reduce number of executed queries), if you want to check it out, see https://github.com/rinvex/laravel-attributes/tree/refactor-to-native-laravel-relationships

Currently no plans to merge that rewrite, but hopefully sometime I can get it to a stable state, improve performance and release it.

I would appreciate any help testing, and improving this new release.

@Omranic Omranic closed this Jul 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants