Staging env fallback for tests #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rioam2
commented
Oct 11, 2019
| @@ -19,6 +19,7 @@ const { exec } = require('child_process'); | |||
| const mergedEnv = { ...dotenv.parsed, ...process.env }; | |||
| const command = process.argv | |||
| .slice(2) | |||
| .map((arg) => (arg.includes(' ') && `'${arg}'`) || arg) | |||
There was a problem hiding this comment.
Needed as multi-word arguments with quotes are passed into node as a single array element with a space in between. The existence of a space means the argument needs to be re-quoted.
May have some adverse side-effects based on if the argument actually contains its own single quotes...
rioam2
commented
Oct 11, 2019
| # Continuous Deployment for staging/production | ||
| if [[ $TRAVIS_BRANCH == 'master' ]]; then | ||
| if [[ $TRAVIS_PULL_REQUEST == 'false' ]]; then | ||
| if [[ ! -z $STATIC_PROD_PROJECT ]] && [[ ! -z $STATIC_DEPLOY_KEY ]]; then |
There was a problem hiding this comment.
These checks are more granular and therefore preferred over the general $TRAVIS_SECURE_ENV_VARS check removed above.
rioam2
commented
Oct 11, 2019
| @@ -19,7 +19,7 @@ | |||
| "preview:staging": "cross-env NODE_ENV=production yarn loadenv ./scripts/preview.sh", | |||
| "setup": "./scripts/setup.js", | |||
| "test": "yarn test:unit && yarn test:cypress", | |||
| "test:cypress": "start-server-and-test 'yarn preview:staging > /dev/null' 3000 'cypress run'", | |||
| "test:cypress": "yarn loadenv yarn start-server-and-test '[ -z %STATIC_STAGE_PROJECT ] && yarn preview:production > /dev/null || yarn preview:staging > /dev/null' 3000 'cypress run'", | |||
There was a problem hiding this comment.
This script is a little messy right now. May be best to migrate into scripts/ as a separate file later on...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #90