fix: exclude explicit casts when source type is object (#400)

riok · May 2, 2023 · 3af9cc9 · 3af9cc9
1 parent b13d364
commit 3af9cc9
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/Riok.Mapperly/Descriptors/MappingBuilders/ExplicitCastMappingBuilder.cs b/src/Riok.Mapperly/Descriptors/MappingBuilders/ExplicitCastMappingBuilder.cs
@@ -1,3 +1,4 @@
+using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
 using Riok.Mapperly.Abstractions;
 using Riok.Mapperly.Descriptors.Mappings;
@@ -15,6 +16,9 @@ public static class ExplicitCastMappingBuilder
         if (ctx.MapperConfiguration.UseDeepCloning && !ctx.Source.IsImmutable() && !ctx.Target.IsImmutable())
             return null;
 
+        if (SymbolEqualityComparer.Default.Equals(ctx.Source, ctx.Compilation.ObjectType))
+            return null;
+
         var conversion = ctx.Compilation.ClassifyConversion(ctx.Source, ctx.Target);
 
         // only allow user defined explicit reference conversions

diff --git a/test/Riok.Mapperly.Tests/Mapping/CastTest.cs b/test/Riok.Mapperly.Tests/Mapping/CastTest.cs
@@ -363,4 +363,14 @@ public void ExplicitCastMappingDisabledShouldDiagnostic()
             .Should()
             .HaveDiagnostic(new(DiagnosticDescriptors.CouldNotCreateMapping));
     }
+
+    [Fact]
+    public void FromObjectExplicitCastShouldBeIgnoredAndDiagnostic()
+    {
+        var source = TestSourceBuilder.Mapping("object", "byte");
+        TestHelper
+            .GenerateMapper(source, TestHelperOptions.AllowDiagnostics)
+            .Should()
+            .HaveDiagnostic(new(DiagnosticDescriptors.CouldNotCreateMapping));
+    }
 }