fix: escape method parameters with reserved keywords (#756)

riok · Sep 20, 2023 · 8f7528a · 8f7528a
1 parent bbac6d0
commit 8f7528a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/Riok.Mapperly/Symbols/MethodParameter.cs b/src/Riok.Mapperly/Symbols/MethodParameter.cs
@@ -6,8 +6,14 @@ namespace Riok.Mapperly.Symbols;
 
 public readonly record struct MethodParameter(int Ordinal, string Name, ITypeSymbol Type)
 {
+    private static readonly SymbolDisplayFormat _parameterNameFormat =
+        new(
+            parameterOptions: SymbolDisplayParameterOptions.IncludeName,
+            miscellaneousOptions: SymbolDisplayMiscellaneousOptions.EscapeKeywordIdentifiers
+        );
+
     public MethodParameter(IParameterSymbol symbol)
-        : this(symbol.Ordinal, symbol.Name, symbol.Type.UpgradeNullable()) { }
+        : this(symbol.Ordinal, symbol.ToDisplayString(_parameterNameFormat), symbol.Type.UpgradeNullable()) { }
 
     public MethodArgument WithArgument(ExpressionSyntax? argument) =>
         new(this, argument ?? throw new ArgumentNullException(nameof(argument)));

diff --git a/test/Riok.Mapperly.Tests/Mapping/MapperTest.cs b/test/Riok.Mapperly.Tests/Mapping/MapperTest.cs
@@ -147,4 +147,11 @@ enum E2 { Value1 }
 
         return TestHelper.VerifyGenerator(source);
     }
+
+    [Fact]
+    public void RestrictedKeywordParametersShouldBeEscaped()
+    {
+        var source = TestSourceBuilder.MapperWithBody("public partial string Map(int @object);");
+        TestHelper.GenerateMapper(source).Should().HaveSingleMethodBody("return @object.ToString();");
+    }
 }