fix: map init only collection in existing target mapping correctly (#…

…1190)
riok · Mar 20, 2024 · c9b4b17 · c9b4b17
1 parent 3bf7bba
commit c9b4b17
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/src/Riok.Mapperly/Descriptors/MappingBodyBuilders/ObjectMemberMappingBodyBuilder.cs b/src/Riok.Mapperly/Descriptors/MappingBodyBuilders/ObjectMemberMappingBodyBuilder.cs
@@ -352,7 +352,11 @@ MemberPath targetMemberPath
         // if the member is readonly
         // and the target and source path is readable,
         // we try to create an existing target mapping
-        if (targetMemberPath.Member.CanSet || !targetMemberPath.Path.All(op => op.CanGet) || !sourceMemberPath.Path.All(op => op.CanGet))
+        if (
+            targetMemberPath.Member is { CanSet: true, IsInitOnly: false }
+            || !targetMemberPath.Path.All(op => op.CanGet)
+            || !sourceMemberPath.Path.All(op => op.CanGet)
+        )
         {
             return false;
         }

diff --git a/test/Riok.Mapperly.Tests/Mapping/EnumerableExistingTargetTest.cs b/test/Riok.Mapperly.Tests/Mapping/EnumerableExistingTargetTest.cs
@@ -107,4 +107,25 @@ public void EnumerableMappingExistingTargetDisabledShouldDiagnostic()
                 """
             );
     }
+
+    [Fact]
+    public void MapToExistingInitOnlyCollection()
+    {
+        var source = TestSourceBuilder.MapperWithBodyAndTypes(
+            "partial void Map(A source, B target);",
+            "class A { public ICollection<string> Subs { get; } = new List<string>(); }",
+            "class B { public ICollection<string> Subs { get; init; } = new List<string>(); }"
+        );
+        TestHelper
+            .GenerateMapper(source)
+            .Should()
+            .HaveSingleMethodBody(
+                """
+                foreach (var item in source.Subs)
+                {
+                    target.Subs.Add(item);
+                }
+                """
+            );
+    }
 }