chore: simplify roslyn multi targeting

riok · Dec 24, 2023 · d0ea66e · d0ea66e
1 parent ca3ea5a
commit d0ea66e
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 31 deletions.
diff --git a/src/Riok.Mapperly/Helpers/IncrementalValuesProviderExtensions.Roslyn4.0.cs b/src/Riok.Mapperly/Helpers/IncrementalValuesProviderExtensions.Roslyn4.0.cs
@@ -0,0 +1,16 @@
+#if !ROSLYN4_4_OR_GREATER
+using Microsoft.CodeAnalysis;
+
+namespace Riok.Mapperly.Helpers;
+
+internal static partial class IncrementalValuesProviderExtensions
+{
+    public static IncrementalValueProvider<TSource> WithTrackingName<TSource>(this IncrementalValueProvider<TSource> source, string name) =>
+        source;
+
+    public static IncrementalValuesProvider<TSource> WithTrackingName<TSource>(
+        this IncrementalValuesProvider<TSource> source,
+        string name
+    ) => source;
+}
+#endif
diff --git a/src/Riok.Mapperly/Helpers/IncrementalValuesProviderExtensions.cs b/src/Riok.Mapperly/Helpers/IncrementalValuesProviderExtensions.cs
@@ -69,21 +69,4 @@ IncrementalValuesProvider<MapperNode> mappers
             }
         );
     }
-
-#if !ROSLYN4_4_OR_GREATER
-    public static IncrementalValuesProvider<TSource> WhereNotNull<TSource>(this IncrementalValuesProvider<TSource?> source)
-    {
-#nullable disable
-        return source.Where(x => x != null);
-#nullable enable
-    }
-
-    public static IncrementalValueProvider<TSource> WithTrackingName<TSource>(this IncrementalValueProvider<TSource> source, string name) =>
-        source;
-
-    public static IncrementalValuesProvider<TSource> WithTrackingName<TSource>(
-        this IncrementalValuesProvider<TSource> source,
-        string name
-    ) => source;
-#endif
 }
diff --git a/src/Riok.Mapperly/Riok.Mapperly.Roslyn4.4.props b/src/Riok.Mapperly/Riok.Mapperly.Roslyn4.4.props
@@ -1,9 +1,5 @@
 <Project>
 
-  <PropertyGroup>
-    <DefineConstants>$(DefineConstants);ROSLYN4_4_OR_GREATER</DefineConstants>
-  </PropertyGroup>
-
   <ItemGroup>
     <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.4.0" PrivateAssets="all" />
   </ItemGroup>

diff --git a/src/Riok.Mapperly/Riok.Mapperly.Roslyn4.5.props b/src/Riok.Mapperly/Riok.Mapperly.Roslyn4.5.props
@@ -1,9 +1,5 @@
 <Project>
 
-  <PropertyGroup>
-    <DefineConstants>$(DefineConstants);ROSLYN4_4_OR_GREATER</DefineConstants>
-  </PropertyGroup>
-
   <ItemGroup>
     <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.5.0" PrivateAssets="all" />
   </ItemGroup>

diff --git a/src/Riok.Mapperly/Riok.Mapperly.Roslyn4.7.props b/src/Riok.Mapperly/Riok.Mapperly.Roslyn4.7.props
@@ -1,10 +1,5 @@
 <Project>
 
-  <PropertyGroup>
-    <DefineConstants>$(DefineConstants);ROSLYN4_4_OR_GREATER</DefineConstants>
-    <DefineConstants>$(DefineConstants);ROSLYN4_7_OR_GREATER</DefineConstants>
-  </PropertyGroup>
-
   <ItemGroup>
     <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.7.0" PrivateAssets="all" />
   </ItemGroup>

diff --git a/src/Riok.Mapperly/Riok.Mapperly.csproj b/src/Riok.Mapperly/Riok.Mapperly.csproj
@@ -16,8 +16,10 @@
     <PackageTags>Mapper SourceGenerator</PackageTags>
     <PackageIcon>logo.png</PackageIcon>
 
-    <!-- default roslyn version -->
+    <!-- default roslyn version and constants -->
     <ROSLYN_VERSION Condition="'$(ROSLYN_VERSION)' == ''">4.7</ROSLYN_VERSION>
+    <DefineConstants Condition="$(ROSLYN_VERSION) >= 4.4">$(DefineConstants);ROSLYN4_4_OR_GREATER</DefineConstants>
+    <DefineConstants Condition="$(ROSLYN_VERSION) >= 4.7">$(DefineConstants);ROSLYN4_7_OR_GREATER</DefineConstants>
   </PropertyGroup>
 
   <Target Name="Husky" BeforeTargets="Restore;CollectPackageReferences" Condition="'$(HUSKY)' != 0 AND '$(CI)' == ''">