Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly annotate nullable generics in disabled nullable contexts #1020

Merged
merged 1 commit into from Dec 18, 2023

Conversation

latonz
Copy link
Contributor

@latonz latonz commented Dec 17, 2023

Closes #1014

@latonz latonz self-assigned this Dec 17, 2023
Copy link

codecov bot commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (567c8b3) 91.35% compared to head (9b9dfea) 91.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
+ Coverage   91.35%   91.37%   +0.01%     
==========================================
  Files         223      223              
  Lines        7221     7231      +10     
  Branches      913      914       +1     
==========================================
+ Hits         6597     6607      +10     
  Misses        412      412              
  Partials      212      212              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@latonz latonz enabled auto-merge (squash) December 17, 2023 15:39
@latonz latonz requested a review from ni507 December 17, 2023 15:39
@latonz latonz merged commit d35c52d into riok:main Dec 18, 2023
19 checks passed
@latonz latonz deleted the fix/nullable-generics branch December 18, 2023 08:40
Copy link

🎉 This PR is included in version 3.3.1-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nullability of reference types does not match target type
2 participants