Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow usage of mappings in MapPropertyAttribute.Use which are attributed with UserMappingAttribute #1151

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

latonz
Copy link
Contributor

@latonz latonz commented Mar 6, 2024

  • Lazy discover named mappings if AutoUserMapping is disabled
  • Correctly resolve external mappings when AutoUserMapping is disabled
  • Allow user-defined mappings references in MapPropertyAttribute.Use

@latonz latonz self-assigned this Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 98.01325% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 91.48%. Comparing base (5a50d81) to head (779c17a).

Files Patch % Lines
...scriptors/InlineExpressionMappingBuilderContext.cs 86.66% 1 Missing and 1 partial ⚠️
...Mappings/UserDefinedExistingTargetMethodMapping.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1151      +/-   ##
==========================================
+ Coverage   91.46%   91.48%   +0.02%     
==========================================
  Files         226      227       +1     
  Lines        7719     7785      +66     
  Branches      978      985       +7     
==========================================
+ Hits         7060     7122      +62     
- Misses        429      431       +2     
- Partials      230      232       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@latonz latonz force-pushed the feat/use-mappings branch 2 times, most recently from 715ce52 to f877ff8 Compare March 6, 2024 07:41
@latonz latonz marked this pull request as ready for review March 6, 2024 07:51
@latonz latonz requested a review from CommonGuy March 6, 2024 07:51
@latonz latonz enabled auto-merge (squash) March 6, 2024 07:51
@latonz latonz merged commit 1f0b3c5 into riok:main Mar 6, 2024
19 checks passed
@latonz latonz deleted the feat/use-mappings branch March 6, 2024 08:18
Copy link

github-actions bot commented Mar 9, 2024

🎉 This PR is included in version 3.5.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants