fix: do not generalise enumerable dictionary value types #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1155 +/- ##
==========================================
- Coverage 91.48% 91.43% -0.05%
==========================================
Files 227 230 +3
Lines 7785 7799 +14
Branches 985 989 +4
==========================================
+ Hits 7122 7131 +9
- Misses 431 433 +2
- Partials 232 235 +3 ☔ View full report in Codecov by Sentry. |
latonz
force-pushed
the
1152-dictionary-with-enumerable-value
branch
from
a5cc868
to
8d0a703
Compare
latonz
force-pushed
the
1152-dictionary-with-enumerable-value
branch
from
8d0a703
to
6d5f70f
Compare
CommonGuy
approved these changes
Mar 8, 2024
latonz
force-pushed
the
1152-dictionary-with-enumerable-value
branch
from
6d5f70f
to
d562370
Compare
|
🎉 This PR is included in version 3.5.0-next.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the dictionary mapping tried to generalise its input source parameter type for better reusability of the generated mapping method. If a dictionary type was constructed for this the key and value mapping source types were used. If the value mapping is also a generalised enumerable mapping the original dictionary source type may not be assignable to the generalised dictionary type due to the change generalisation the value type.
Fixes #1152