Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accept destination type as mapping method parameter #398

Merged
merged 1 commit into from May 10, 2023

Conversation

latonz
Copy link
Contributor

@latonz latonz commented May 1, 2023

  • Support runtime type mapping methods
  • Support reference handling
  • Support derived type mappings on the same method with duplicated source types
  • Add unit tests
  • Add integration tests
  • Update documentation

Closes #349

@latonz latonz self-assigned this May 1, 2023
@latonz latonz force-pushed the 349-type-as-parameter branch 5 times, most recently from 2027f7d to f60ef8e Compare May 2, 2023 07:23
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Merging #398 (a003c60) into main (e5e2d1c) will increase coverage by 0.31%.
The diff coverage is 89.38%.

❗ Current head a003c60 differs from pull request most recent head 9b6451c. Consider uploading reports for the commit 9b6451c to get more accurate results

@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
+ Coverage   91.73%   92.04%   +0.31%     
==========================================
  Files         126      135       +9     
  Lines        3931     4276     +345     
  Branches      548      591      +43     
==========================================
+ Hits         3606     3936     +330     
- Misses        214      225      +11     
- Partials      111      115       +4     
Impacted Files Coverage Δ
src/Polyfills/Nullable.cs 0.00% <0.00%> (ø)
...k.Mapperly.Abstractions/MapDerivedTypeAttribute.cs 0.00% <0.00%> (ø)
...iok.Mapperly.Abstractions/MapperIgnoreAttribute.cs 100.00% <ø> (ø)
...pperly.Abstractions/MapperIgnoreSourceAttribute.cs 100.00% <ø> (ø)
...pperly.Abstractions/MapperIgnoreTargetAttribute.cs 100.00% <ø> (ø)
.../Riok.Mapperly/Descriptors/Mappings/TypeMapping.cs 100.00% <ø> (ø)
.../Riok.Mapperly/Helpers/NullableSymbolExtensions.cs 92.59% <0.00%> (-3.57%) ⬇️
...ok.Mapperly/Configuration/AttributeDataAccessor.cs 73.33% <66.66%> (-1.67%) ⬇️
src/Riok.Mapperly/Descriptors/TypeMappingKey.cs 82.35% <82.35%> (ø)
...Mapperly/Descriptors/UserMethodMappingExtractor.cs 92.07% <89.13%> (-0.37%) ⬇️
... and 32 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@latonz latonz force-pushed the 349-type-as-parameter branch 11 times, most recently from 5281cee to 1059396 Compare May 9, 2023 07:34
@latonz latonz force-pushed the 349-type-as-parameter branch 6 times, most recently from 95d60b9 to 3a58e7d Compare May 9, 2023 08:44
@latonz latonz marked this pull request as ready for review May 9, 2023 08:51
@latonz latonz enabled auto-merge (squash) May 9, 2023 08:52
@latonz latonz force-pushed the 349-type-as-parameter branch 4 times, most recently from 0abd6ca to a003c60 Compare May 9, 2023 09:12
@latonz latonz requested a review from ni507 May 9, 2023 18:23
@latonz latonz merged commit b17f666 into riok:main May 10, 2023
13 of 14 checks passed
@latonz latonz deleted the 349-type-as-parameter branch May 10, 2023 07:28
@latonz latonz added this to the v2.9.0 milestone Jun 14, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support accepting destination type as a parameter
3 participants