fix: lambdas should use correct scopes to generate names #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #411 +/- ##
==========================================
+ Coverage 91.73% 91.86% +0.13%
==========================================
Files 126 130 +4
Lines 3931 4119 +188
Branches 548 569 +21
==========================================
+ Hits 3606 3784 +178
- Misses 214 221 +7
- Partials 111 114 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@TimothyMakkison as you contributed several cool features and fixes in the recent past and got to know the code base pretty good, if you feel like it, an additional review from you would be appreciated 😊. |
ni507
approved these changes
May 8, 2023
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name builder created for lambda parameters wasn't used in the context created to build mappings inside those lambdas. This could lead to name conflicts.